[webkit-reviews] review granted: [Bug 120581] [GTK] Color of input button's text broken with recent gnome-themes-standard : [Attachment 210449] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 4 05:57:51 PDT 2013


Carlos Garcia Campos <cgarcia at igalia.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 120581: [GTK] Color of input button's text broken with recent
gnome-themes-standard
https://bugs.webkit.org/show_bug.cgi?id=120581

Attachment 210449: Patch
https://bugs.webkit.org/attachment.cgi?id=210449&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210449&action=review


Thanks!

> Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:96
> +    else if (widgetType == GTK_TYPE_BUTTON) {
>	   gtk_widget_path_iter_add_class(path, 0, GTK_STYLE_CLASS_BUTTON);
> +	   gtk_widget_path_iter_add_class(path, 1, "text-button");
> +    }

I guess we don't have image buttons in WebKit, so we can assume that web
buttons are always text buttons.


More information about the webkit-reviews mailing list