[webkit-reviews] review denied: [Bug 112842] AX: when no other label on provided on form elements, WebKit should fall back to using @title : [Attachment 210413] Patch.

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Samuel White
<samuel_white at apple.com>'s request for review:
Bug 112842: AX: when no other label on provided on form elements, WebKit should
fall back to using @title
https://bugs.webkit.org/show_bug.cgi?id=112842

Attachment 210413: Patch.
https://bugs.webkit.org/attachment.cgi?id=210413&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210413&action=review


patch looks good otherwise.

> LayoutTests/ChangeLog:1
> +2013-09-03  Samuel White  <samuel_white at da0602a-dhcp103.apple.com>

ditto about email address

> Source/WebCore/ChangeLog:1
> +2013-09-03  Samuel White  <samuel_white at da0602a-dhcp103.apple.com>

you need to fix your email address here. I believe you can set this in your
bash profile

> Source/WebCore/ChangeLog:8
> +	   Don't let input elements include empty labels in their

no need for two lines here.