[webkit-reviews] review granted: [Bug 114873] [GTK] Reimplement atk_text_get_text_*_offset for SENTENCE boundaries : [Attachment 210364] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 3 23:07:19 PDT 2013

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 114873: [GTK] Reimplement atk_text_get_text_*_offset for SENTENCE

Attachment 210364: Patch proposal

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210364&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:916
> +static char* webkitAccessibleTextGetSentenceForBoundary(AtkText* text, int
offset, AtkTextBoundary boundaryType, GetTextRelativePosition textPosition,
int* startOffset, int* endOffset)

you don't need Get in the method name

More information about the webkit-reviews mailing list