[webkit-reviews] review granted: [Bug 120650] Get MEDIA_STREAM compiling on OS X : [Attachment 210410] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 120650: Get MEDIA_STREAM compiling on OS X
https://bugs.webkit.org/show_bug.cgi?id=120650

Attachment 210410: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=210410&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210410&action=review


> Source/WebCore/Modules/mediastream/MediaStreamRegistry.cpp:61
> -    return m_streamDescriptors.get(url).get();
> +    
> +    RefPtr<MediaStreamDescriptor> descriptor = m_streamDescriptors.get(url);

> +    return descriptor.get();

What typecast does this avoid? I don’t understand. The old code looks better
than the new.

> Source/WebCore/Modules/mediastream/RTCSessionDescription.cpp:100
>  void RTCSessionDescription::setSdp(const String& sdp, ExceptionCode& ec)

Why include this ExceptionCode argument if it‘s always zero? Better to fix the
IDL file.

> Source/WebCore/Modules/mediastream/RTCStatsResponse.cpp:51
> +    return m_idmap.find(name) != m_idmap.end();

Should use contains, not find != end.