[webkit-reviews] review granted: [Bug 120615] CodeBlock memory cost reporting should be rationalized : [Attachment 210415] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 3 19:19:22 PDT 2013
Darin Adler <darin at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 120615: CodeBlock memory cost reporting should be rationalized
https://bugs.webkit.org/show_bug.cgi?id=120615
Attachment 210415: the patch
https://bugs.webkit.org/attachment.cgi?id=210415&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210415&action=review
> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1851
> + m_heap->reportExtraMemoryCost(
> + sizeof(CodeBlock) + m_instructions.size() * sizeof(Instruction));
Why the strange line breaking? Looks like this all would fit on one line just
fine.
> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1940
> + visitor.reportExtraMemoryUsage(
> + m_instructions.size() * sizeof(Instruction) /
m_instructions.refCount());
Same line breaking comment. Also, the division by reference count is
sufficiently non-obvious that I would include a comment, unless this is a
common JavaScriptCore idiom that I am unaware of.
More information about the webkit-reviews
mailing list