[webkit-reviews] review granted: [Bug 120641] [Mac] Hyphenation respects regional format settings language instead of primary language : [Attachment 210389] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 3 11:04:51 PDT 2013


mitz at webkit.org <mitz at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 120641: [Mac] Hyphenation respects regional format settings language
instead of primary language
https://bugs.webkit.org/show_bug.cgi?id=120641

Attachment 210389: proposed fix
https://bugs.webkit.org/attachment.cgi?id=210389&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=210389&action=review


> Source/WebCore/platform/text/cf/HyphenationCF.cpp:40
> +    // Fall back to a locale created from user's default language
(respecting testing overrides).

I don’t think the parenthetical is helpful.

> LayoutTests/ChangeLog:9
> +	   expected pixel results in mac-lion dorectory.

Typo: dorectory


More information about the webkit-reviews mailing list