[webkit-reviews] review granted: [Bug 120460] Web Inspector: exceptions triggered from console evaluation do not pause the debugger : [Attachment 210387] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 120460: Web Inspector: exceptions triggered from console evaluation do not
pause the debugger
https://bugs.webkit.org/show_bug.cgi?id=120460

Attachment 210387: Patch
https://bugs.webkit.org/attachment.cgi?id=210387&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210387&action=review


> Source/WebInspectorUI/UserInterface/CallFrameTreeElement.js:43
> +	   title = WebInspector.UIString("Console Prompt");

You will still see "__WebInspectorConsole__" in the navigation bar and the
Resour

> Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js:686
> +	   // Exclude inspector scripts.
> +	   if (script.url.indexOf("__WebInspector") === 0)
> +	       return;

This might cause issues if you select the "Console Prompt" call frame. We will
try to show the script, which might work, but the navigation bar will be blank
because it wasn't added to the sidebar. We might need to just hide the
"__WebInspectorConsole__" frame in the call stack and prevent showing the
source.