[webkit-reviews] review denied: [Bug 120455] [GTK] Add wayland-dependencies modulesset to jhbuild-optional.modules : [Attachment 210069] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied ChangSeok Oh
<changseok.oh at collabora.com>'s request for review:
Bug 120455: [GTK] Add wayland-dependencies modulesset to
jhbuild-optional.modules
https://bugs.webkit.org/show_bug.cgi?id=120455

Attachment 210069: Patch
https://bugs.webkit.org/attachment.cgi?id=210069&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=210069&action=review


I defer to Zan on the versions that should be used, though, and whether it
makes sense to add wayland modules themselves.

> Tools/gtk/jhbuild-optional.modules:50
> +  <autotools id="glib-for-wayland"

hmm, I think you should not use the -for-wayland suffix. These definitions
should override the definitions in the main modules file instead - which makes
sense, since they *will* be installed instead of/on top of the original ones.