[webkit-reviews] review granted: [Bug 123380] JSExport doesn't support constructors : [Attachment 215536] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 123380: JSExport doesn't support constructors
https://bugs.webkit.org/show_bug.cgi?id=123380

Attachment 215536: Patch
https://bugs.webkit.org/attachment.cgi?id=215536&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215536&action=review


> Source/JavaScriptCore/API/JSWrapperMap.mm:162
> +static bool shouldSkipMethodWithName(NSString *name)

inline?

> Source/JavaScriptCore/API/JSWrapperMap.mm:169
> +#if OS(DARWIN)
> +    if (NSVersionOfLinkTimeLibrary("JavaScriptCore") <
webkitFirstVersionWithInitConstructorSupport)
> +	   return false;
> +#endif

Is this fast enough to re-evaluate every time, or should we cache it in a
global?

> Source/JavaScriptCore/API/JSWrapperMap.mm:173
> +    // Skip over init family methods because we handle those specially 
> +    // for the purposes of hooking up the constructor correctly.
> +    return [name hasPrefix:@"init"];

Is this the correct definition for “init family”? It would return true for a
property named “initials” or “initialCharacter” or “initialSize”.