[webkit-reviews] review denied: [Bug 103707] AssemblyHelpers::decodedCodeMapFor crash : [Attachment 181285] patch to this crash

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has denied linzj <manjian2006 at gmail.com>'s
request for review:
Bug 103707: AssemblyHelpers::decodedCodeMapFor crash
https://bugs.webkit.org/show_bug.cgi?id=103707

Attachment 181285: patch to this crash
https://bugs.webkit.org/attachment.cgi?id=181285&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=181285&action=review


Rebase patch, make sure it builds and then resubmit for review.

> Source/JavaScriptCore/jit/JIT.cpp:754
> +/*!! begin change by linzj !!*/
> +    if (true
> +// when compiling osrExit ,the jit code map is needed for jumping.The dfg
optimized code is able to jump to
> +// any base line code no matter if  it is able to be optimized.So this fix
will allow jit to collect jit code map
> +// for current code block in all conditions.
> +/*!! end change by linzj !!*/

Eliminate the /*!! … !!*/ comments.
Not sure how many of the other comments are needed.  If you still think
some/all of these comment need to be present, make these complete sentences
beginning with a capitalized word and with a space after the '.'