[webkit-reviews] review granted: [Bug 112017] [EFL] accessibility/textbox-role-reports-selection.html is failing : [Attachment 215480] Proposed patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted Rob Płóciennik
<r.plociennik at samsung.com>'s request for review:
Bug 112017: [EFL] accessibility/textbox-role-reports-selection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112017

Attachment 215480: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=215480&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215480&action=review


Lgtm, but it would be good if you could address those style things first

> LayoutTests/ChangeLog:7
> +

Small description here?

> Source/WebCore/ChangeLog:11
> +	   No new tests, covered by existing ones.
> +
> +	   getSelectionOffsetsForObject() now returns proper start/end offsets
for
> +	   selections "touching" the object's front border.

You probably want to swap the order of these two paragraphs