[webkit-reviews] review granted: [Bug 112016] [EFL] accessibility/textarea-selected-text-range.html is failing : [Attachment 215481] Proposed patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted Rob Płóciennik
<r.plociennik at samsung.com>'s request for review:
Bug 112016: [EFL] accessibility/textarea-selected-text-range.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112016

Attachment 215481: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=215481&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215481&action=review


Lgtm, besides some small style nits.

> LayoutTests/ChangeLog:7
> +

We normally put a brief and generic description such as "Removed failure
expectations" or the like

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1026
> +    gint start, end;
> +    g_free(atk_text_get_selection(ATK_TEXT(m_element), 0, &start, &end));

This g_free(...) thing is a weird idiom, but I guess it's fine here since you
are only interested in the offsets. Ok

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1029
> +

Extra blank line not needed

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1169
> +

Extra line