[webkit-reviews] review granted: [Bug 121954] [MediaStream API] allow a stream source to be shared : [Attachment 215099] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 121954: [MediaStream API] allow a stream source to be shared
https://bugs.webkit.org/show_bug.cgi?id=121954

Attachment 215099: Patch
https://bugs.webkit.org/attachment.cgi?id=215099&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215099&action=review


> Source/WebCore/Modules/mediastream/MediaStream.cpp:356
> +    for (int i : tracksToRemove) {
> +	   RefPtr<MediaStreamTrack> track = (*tracks)[i];
> +	   track->removeObserver(this);
> +	   tracks->remove(i);
> +	  
scheduleDispatchEvent(MediaStreamTrackEvent::create(eventNames().removetrackEve
nt, false, false, track.release()));
> +    }

Doesn't this need to loop backwards through the tracks since you are removing
them by index?