[webkit-reviews] review granted: [Bug 123288] Crash in WebCore::NavigationScheduler::startTimer() : [Attachment 215100] Patch and API test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 24 13:38:22 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 123288: Crash in WebCore::NavigationScheduler::startTimer()
https://bugs.webkit.org/show_bug.cgi?id=123288

Attachment 215100: Patch and API test
https://bugs.webkit.org/attachment.cgi?id=215100&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215100&action=review


r=me. Please wait for EWS to become green.

> Tools/TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html:4
> +<iframe id="frame" src="about: blank"></iframe>

Maybe "about:blank" to make it less confusing?

> Tools/TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm:34
> +static NSURL* testURL()

Star is misplaced.


More information about the webkit-reviews mailing list