[webkit-reviews] review denied: [Bug 122365] Include misspelling dot gap width when centering misspelling dots : [Attachment 214985] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 122365: Include misspelling dot gap width when centering misspelling dots
https://bugs.webkit.org/show_bug.cgi?id=122365

Attachment 214985: Patch
https://bugs.webkit.org/attachment.cgi?id=214985&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214985&action=review


> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:-170
> -    // NOTE: Code here used to shift the underline to the left and increase
the width
> -    // to make sure everything gets underlined, but that results in drawing
out of
> -    // bounds (e.g. when at the edge of a view) and could make it appear
that the
> -    // space between adjacent misspelled words was underlined.

I would like to see your testcase testing "the space between misspelled words".