[webkit-reviews] review requested: [Bug 123201] [WK2] [GTK] Allow running the web process with an arbitrary prefix command : [Attachment 215001] Patch

[bugzilla-daemon at webkit.org]

Alberto Garcia <berto at igalia.com> has asked  for review:
Bug 123201: [WK2] [GTK] Allow running the web process with an arbitrary prefix
command
https://bugs.webkit.org/show_bug.cgi?id=123201

Attachment 215001: Patch
https://bugs.webkit.org/attachment.cgi?id=215001&action=review

------- Additional Comments from Alberto Garcia <berto at igalia.com>
I fixed the style problem in WebProcessProxy.cpp but otherwise the
code is essentially the same.

I rewrote the ProcessLauncher::launchProcess() part so it's hopefully
a bit clearer now.

As I explained earlier I don't think it's easy to do without the
intermediate array. It's anyway necessary to split the string first in
order to know how much memory we need to allocate for argv.

In this patch I also put the prefixArgs vector inside the #ifndef NDEBUG
block, so for release builds the code is almost identical.