[webkit-reviews] review granted: [Bug 122757] Transition *switch* and *scope* JITStubs to JIT operations : [Attachment 214202] the patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 14 19:36:28 PDT 2013
Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 122757: Transition *switch* and *scope* JITStubs to JIT operations
https://bugs.webkit.org/show_bug.cgi?id=122757
Attachment 214202: the patch.
https://bugs.webkit.org/attachment.cgi?id=214202&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214202&action=review
Needs some fixes before landing.
> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1009
> + ASSERT(returnValueRegister == regT0);
> jump(regT0);
Please use returnValueRegister in the jump, and remove the ASSERT.
> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1026
> + ASSERT(returnValueRegister == regT0);
> jump(regT0);
Ditto.
> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1042
> + ASSERT(returnValueRegister == regT0);
> jump(regT0);
Ditto.
> Source/JavaScriptCore/jit/JITOpcodes.cpp:695
> + emitGetVirtualRegister(scrutinee, regT1);
> + callOperation(operationSwitchImmWithUnknownKeyType, regT1, tableIndex);
This should be regT0.
> Source/JavaScriptCore/jit/JITOpcodes.cpp:697
> + ASSERT(returnValueRegister == regT0);
> jump(regT0);
This should be returnValueRegister.
> Source/JavaScriptCore/jit/JITOpcodes.cpp:712
> + emitGetVirtualRegister(scrutinee, regT1);
> + callOperation(operationSwitchCharWithUnknownKeyType, regT1, tableIndex);
regT0.
> Source/JavaScriptCore/jit/JITOpcodes.cpp:714
> + ASSERT(returnValueRegister == regT0);
> jump(regT0);
returnValueRegister.
> Source/JavaScriptCore/jit/JITOpcodes.cpp:730
> + emitGetVirtualRegister(scrutinee, regT1);
> + callOperation(operationSwitchStringWithUnknownKeyType, regT1,
tableIndex);
> + ASSERT(returnValueRegister == regT0);
> jump(regT0);
Ditto.
More information about the webkit-reviews
mailing list