[webkit-reviews] review granted: [Bug 122804] EventPath::updateTouchLists traverses through EventPath thrice : [Attachment 214220] Fixed builds
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 14 19:13:51 PDT 2013
Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 122804: EventPath::updateTouchLists traverses through EventPath thrice
https://bugs.webkit.org/show_bug.cgi?id=122804
Attachment 214220: Fixed builds
https://bugs.webkit.org/attachment.cgi?id=214220&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214220&action=review
> Source/WebCore/dom/EventDispatcher.cpp:444
> + const size_t touchNodeCount = touchEvent.touches()->length() +
touchEvent.targetTouches()->length() + touchEvent.changedTouches()->length();
No need for the const.
I think "touchNode" is confusing. Use totalTouchesCount instead?
More information about the webkit-reviews
mailing list