[webkit-reviews] review denied: [Bug 122762] [iOS] Upstream JavaScriptCore support for ARM64 : [Attachment 214167] Offlineasm changes

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 122762: [iOS] Upstream JavaScriptCore support for ARM64
https://bugs.webkit.org/show_bug.cgi?id=122762

Attachment 214167: Offlineasm changes
https://bugs.webkit.org/attachment.cgi?id=214167&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214167&action=review


> Source/JavaScriptCore/offlineasm/risc_arm64.rb:31
> +# Copyright (C) 2012 Apple Inc. All rights reserved.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +# 1. Redistributions of source code must retain the above copyright
> +#	notice, this list of conditions and the following disclaimer.
> +# 2. Redistributions in binary form must reproduce the above copyright
> +#	notice, this list of conditions and the following disclaimer in the
> +#	documentation and/or other materials provided with the distribution.
> +#
> +# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
> +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
> +# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> +# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
> +# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
> +# THE POSSIBILITY OF SUCH DAMAGE.
> +
> +require 'ast'
> +require 'opt'
> +require 'risc'
> +
> +# This file contains utilities that should be in risc.rb if it wasn't for
the
> +# fact that risc.rb is shared with the ARMv7 backend, and may be part of a
> +# code dump before ARM64 goes public.
> +#

I would merge this entire file with risk.rb.

> Source/JavaScriptCore/offlineasm/risc_arm64.rb:32
> +# FIXME: when ARM64 goes public, we should merge this file into risc.rb

:-/