[webkit-reviews] review granted: [Bug 122762] [iOS] Upstream JavaScriptCore support for ARM64 : [Attachment 214164] JIT changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 14 10:59:07 PDT 2013


Oliver Hunt <oliver at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 122762: [iOS] Upstream JavaScriptCore support for ARM64
https://bugs.webkit.org/show_bug.cgi?id=122762

Attachment 214164: JIT changes
https://bugs.webkit.org/attachment.cgi?id=214164&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214164&action=review


>> Source/JavaScriptCore/jit/ThunkGenerators.cpp:424
>> +	// Calling convention:	    f(edi, esi, edx, ecx, ...);
> 
> Should have only a single space after a punctuation in a comment. 
[whitespace/comments] [5]

this comment is clearly wrong, bug to fix it  please


More information about the webkit-reviews mailing list