[webkit-reviews] review denied: [Bug 122645] Transition misc cti_op_* JITStubs to JIT operations : [Attachment 214114] the patch.

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 122645: Transition misc cti_op_* JITStubs to JIT operations
https://bugs.webkit.org/show_bug.cgi?id=122645

Attachment 214114: the patch.
https://bugs.webkit.org/attachment.cgi?id=214114&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214114&action=review


> Source/JavaScriptCore/jit/CCallHelpers.h:963
> +	   move(arg2, GPRInfo::argumentGPR2); // In case the incoming arg2 was
in argumentGPR1.

The comment should actually read "In case arg2 is argumentGPR1".

> Source/JavaScriptCore/jit/JIT.h:541
> +	   void emitGetVirtualRegister(int index, RegisterID tag, RegisterID
payload);

How is this different than emitLoad(int index, RegisterID tag, RegisterID
payload, RegisterID base = callFrameRegister) below?

> Source/JavaScriptCore/jit/JITInlines.h:725
> +inline void JIT::emitGetVirtualRegister(int index, RegisterID tag,
RegisterID payload)
> +{
> +    emitLoadTag(index, tag);
> +    emitLoadPayload(index, payload);
> +}

Remove, this is the same as inline void JIT::emitLoad(int index, RegisterID
tag, RegisterID payload, RegisterID base)