[webkit-reviews] review denied: [Bug 97516] [CMake] Remove support for cmake version < 2.8.3 : [Attachment 214018] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied  review:
Bug 97516: [CMake] Remove support for cmake version < 2.8.3
https://bugs.webkit.org/show_bug.cgi?id=97516

Attachment 214018: Patch
https://bugs.webkit.org/attachment.cgi?id=214018&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214018&action=review


>>>> Source/cmake/FindCairo.cmake:-78
>>>> -endif ()
>>> 
>>> I am not sure.
>>> With this patch, find_package(Cairo 999.10.2 REQUIRED) is fine.
>> 
>> This review comment isn't clear for me. Currently we use "Cairo 1.10.2" for
EFL and GTK ports. Do you mean this patch will not support 999.10.2 version
style ?
> 
> I mean that FindCairo.cmake will not complain with this pacth although
find_package requests higher version than current version which system have.
> 
> 999.10.2 is just one of example, which is higher version than currently
installed.
> 
> I think that FindCairo.cmake should raise assert when find_package request
higer version.

Ok, I see. This patch can't generate compilation fail when higher version is
required. This patch should check if higher version is required.