[webkit-reviews] review granted: [Bug 116189] FTL memory allocator should be able to allocate data sections in non-executable memory : [Attachment 213621] the patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 116189: FTL memory allocator should be able to allocate data sections in
non-executable memory
https://bugs.webkit.org/show_bug.cgi?id=116189

Attachment 213621: the patch
https://bugs.webkit.org/attachment.cgi?id=213621&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213621&action=review


> Source/JavaScriptCore/ftl/FTLJITCode.h:61
>      const Vector<RefPtr<ExecutableMemoryHandle> >& handles() const { return
m_handles; }
> +    const Vector<RefCountedArray<LSectionWord> >& dataSections() const {
return m_dataSections; }

You don't need the space between the > >.

> Source/JavaScriptCore/ftl/FTLJITCode.h:73
> +    Vector<RefCountedArray<LSectionWord> > m_dataSections;
>      Vector<RefPtr<ExecutableMemoryHandle> > m_handles;

You don't need the space between the > >.