[webkit-reviews] review granted: [Bug 122469] Clean up ScriptExecutionContext::Task and subclasses : [Attachment 213620] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 122469: Clean up ScriptExecutionContext::Task and subclasses
https://bugs.webkit.org/show_bug.cgi?id=122469

Attachment 213620: Patch
https://bugs.webkit.org/attachment.cgi?id=213620&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213620&action=review


> Source/WebCore/Modules/webdatabase/Database.cpp:89
> +    DerefContextTask(PassRefPtr<ScriptExecutionContext> context)

explicit

> Source/WebCore/Modules/webdatabase/Database.cpp:203
> +    DeliverPendingCallbackTask(PassRefPtr<SQLTransaction> transaction)

explicit

>
Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:2
36
> +    Vector<std::unique_ptr<ScriptExecutionContext::Task>> tasks =
std::move(m_pendingTasks);

auto

> Source/WebCore/bindings/js/JSCallbackData.h:80
> +    DeleteCallbackDataTask(JSCallbackData* data)

explicit

> Source/WebCore/dom/Document.cpp:4900
> -	   OwnPtr<Task> task = m_pendingTasks[0].release();
> +	   auto task = std::move(m_pendingTasks[0]);
>	   m_pendingTasks.remove(0);

This code looks pretty inefficient, taking the first element out of a vector in
a loop :|

> Source/WebCore/workers/WorkerMessagingProxy.cpp:156
>      WorkerTerminateTask(WorkerMessagingProxy* messagingProxy)

explicit

> Source/WebCore/workers/WorkerMessagingProxy.cpp:213
>      NotifyNetworkStateChangeTask(bool isOnLine)

explicit