[webkit-reviews] review granted: [Bug 94036] [WebGL] program should not be able to link if a bad shader is attached : [Attachment 213429] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 5 00:39:54 PDT 2013


Darin Adler <darin at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 94036: [WebGL] program should not be able to link if a bad shader is
attached
https://bugs.webkit.org/show_bug.cgi?id=94036

Attachment 213429: Patch
https://bugs.webkit.org/attachment.cgi?id=213429&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213429&action=review


> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:1301
> +    shader->setValid(!!value);

Don't need the !! with C++ bool; just "value" will work fine.


More information about the webkit-reviews mailing list