[webkit-reviews] review granted: [Bug 122369] Undo texture unit code refactoring - it is ok to bind a texture to multiple locations : [Attachment 213432] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 122369: Undo texture unit code refactoring - it is ok to bind a texture to
multiple locations
https://bugs.webkit.org/show_bug.cgi?id=122369

Attachment 213432: Patch
https://bugs.webkit.org/attachment.cgi?id=213432&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213432&action=review


> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:607
> +	   m_textureUnits[i].m_texture2DBinding = 0;
> +	   m_textureUnits[i].m_textureCubeMapBinding = 0;

nullptr is what we now use instead of 0 in new code like this

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:1634
> +	       m_textureUnits[i].m_texture2DBinding = 0;

nullptr

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:1636
> +	       m_textureUnits[i].m_textureCubeMapBinding = 0;

nullptr

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4877
> +    WebGLTexture* tex = 0;

nullptr

Also, can we call this texture instead of tex?

> Source/WebCore/html/canvas/WebGLRenderingContext.h:453
> +    class TextureUnitState {
> +    public:

struct seems better than class/public, although normally we do not use the m_
prefix on public data members in structs like this