[webkit-reviews] review granted: [Bug 122284] Move IDBFactoryBackend creation to DatabaseStrategy : [Attachment 213274] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 3 10:38:12 PDT 2013
Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 122284: Move IDBFactoryBackend creation to DatabaseStrategy
https://bugs.webkit.org/show_bug.cgi?id=122284
Attachment 213274: Patch v1
https://bugs.webkit.org/attachment.cgi?id=213274&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213274&action=review
> Source/WebCore/Modules/indexeddb/IDBFactory.h:60
> + // FIXME: getDatabaseNames is no longer a web-facting API, and should be
removed from IDBFactory.
*web-facing*
> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:221
> + return DatabaseStrategy::createIDBFactoryBackend(); // Use the default
for now.
I don't think that a "for now" comment helps, it should either be more
detailed, or removed.
More information about the webkit-reviews
mailing list