[webkit-reviews] review denied: [Bug 122282] Move float logical location/dimension methods to FloatingObjects : [Attachment 213273] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 122282: Move float logical location/dimension methods to FloatingObjects
https://bugs.webkit.org/show_bug.cgi?id=122282

Attachment 213273: Patch
https://bugs.webkit.org/attachment.cgi?id=213273&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213273&action=review


> Source/WebCore/rendering/FloatingObjects.h:152
> +    LayoutUnit logicalTopForFloat(const FloatingObject* floatingObject)
const { return m_horizontalWritingMode ? floatingObject->y() :
floatingObject->x(); }
> +    LayoutUnit logicalBottomForFloat(const FloatingObject* floatingObject)
const { return m_horizontalWritingMode ? floatingObject->maxY() :
floatingObject->maxX(); }
> +    LayoutUnit logicalLeftForFloat(const FloatingObject* floatingObject)
const { return m_horizontalWritingMode ? floatingObject->x() :
floatingObject->y(); }
> +    LayoutUnit logicalRightForFloat(const FloatingObject* floatingObject)
const { return m_horizontalWritingMode ? floatingObject->maxX() :
floatingObject->maxY(); }
> +    LayoutUnit logicalWidthForFloat(const FloatingObject* floatingObject)
const { return m_horizontalWritingMode ? floatingObject->width() :
floatingObject->height(); }
> +    LayoutUnit logicalHeightForFloat(const FloatingObject* floatingObject)
const { return m_horizontalWritingMode ? floatingObject->height() :
floatingObject->width(); }

You should add corresponding methods to RenderBlock. There's no reason to force
callers to fetch floatingObjects() just to ask about a float. I think it's fine
to add these methods here, but you should add wrappers in RenderBlock so that
the call sites don't have to retrieve a floatingObjects().