[webkit-reviews] review granted: [Bug 124862] Expose a way to detect page zoom : [Attachment 217841] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 26 19:17:04 PST 2013


Brent Fulgham <bfulgham at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 124862: Expose a way to detect page zoom
https://bugs.webkit.org/show_bug.cgi?id=124862

Attachment 217841: Patch
https://bugs.webkit.org/attachment.cgi?id=217841&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217841&action=review


Seems pretty straightforward to me.  r=me, whenever you want to land it.

> Source/WebCore/page/DOMWindow.h:233
> +	   double webkitPageZoomRatio() const;

Should we bother calling this "webkitPageZoomRatio" here? I think it make sense
to expose this to users with a webkit-prefix, but here in the guts of WebKit it
seems redundant.


More information about the webkit-reviews mailing list