[webkit-reviews] review granted: [Bug 124872] Remote Layer Tree: Hook up setLayerTreeStateIsFrozen : [Attachment 217849] patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 124872: Remote Layer Tree: Hook up setLayerTreeStateIsFrozen
https://bugs.webkit.org/show_bug.cgi?id=124872

Attachment 217849: patch
https://bugs.webkit.org/attachment.cgi?id=217849&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217849&action=review


r=me. But please consider whether the "optimization" or "flush avoidance" I
suggested makes any sense.

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:145
> +    if (!m_isFlushingSuspended && m_hasDeferredFlush) {

Should we bother checking if our original state was already
"!m_isFlushingSuspended" and only schedule the layer flush for the case where
state is changing?

I.e.:

if (m_isFlushingSuspended == isFrozen)
    return;

... before doing the rest of your code?