[webkit-reviews] review granted: [Bug 124904] Add a bunch of early exits and local optimizations to the x86 assembler. : [Attachment 217911] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 26 17:12:37 PST 2013


Filip Pizlo <fpizlo at apple.com> has granted Nadav Rotem <nrotem at apple.com>'s
request for review:
Bug 124904: Add a bunch of early exits and local optimizations to the x86
assembler.
https://bugs.webkit.org/show_bug.cgi?id=124904

Attachment 217911: Patch
https://bugs.webkit.org/attachment.cgi?id=217911&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Yup, this looks right. Fwiw, if a client of this API wants flags they have to
call branchBlah. I think the arm assemblers may implement bramchBlah in terms
of blah so you'd have to be careful there.


More information about the webkit-reviews mailing list