[webkit-reviews] review denied: [Bug 120059] Add support for maction at toggle : [Attachment 211773] Patch V3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 26 17:14:53 PST 2013
Brent Fulgham <bfulgham at webkit.org> has denied review:
Bug 120059: Add support for maction at toggle
https://bugs.webkit.org/show_bug.cgi?id=120059
Attachment 211773: Patch V3
https://bugs.webkit.org/attachment.cgi?id=211773&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211773&action=review
A few minor changes, based in part of comments Darin made for Bug 120058.
> Source/WebCore/mathml/MathMLSelectElement.cpp:162
> + unsigned int selection = (hasAttribute(MathMLNames::selectionAttr) ?
getAttribute(MathMLNames::selectionAttr).toInt(&ok) : 1);
This should be "fastGetAttribute(MathMLNames::selectionAttr) (see Darin's
comments in 120058).
> Source/WebCore/mathml/MathMLSelectElement.cpp:172
> + }
Please revise this logic as Darin asked in Bug 120058:
int i = 1;
for (; i <= selection; i++) {
Element* nextChild = child->nextElementSibling();
if (!nextChild)
break;
child = nextChild;
}
More information about the webkit-reviews
mailing list