[webkit-reviews] review granted: [Bug 124368] [CSS Shapes] Add BoxShape and FloatRoundingRect classes : [Attachment 217451] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 124368: [CSS Shapes] Add BoxShape and FloatRoundingRect classes
https://bugs.webkit.org/show_bug.cgi?id=124368

Attachment 217451: Patch
https://bugs.webkit.org/attachment.cgi?id=217451&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217451&action=review


> Source/WebCore/platform/graphics/FloatRoundedRect.cpp:4
> +/*
> + * Copyright (C) 2003, 2006, 2009 Apple Inc. All rights reserved.
> + * Copyright (C) 2010 Google Inc. All rights reserved.
> + * Copyright (C) 2013 Xidorn Quan (quanxunzhen at gmail.com)

This doesn't match the .h

> Source/WebCore/platform/graphics/FloatRoundedRect.cpp:106
> +    if (y < rect().y()  || y >=  rect().maxY())

Double space before ||

> Source/WebCore/platform/graphics/FloatRoundedRect.h:2
> +/*
> + * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.

2013