[webkit-reviews] review denied: [Bug 124650] Move stray urls into common.config.urls : [Attachment 217414] Proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Dániel Bátyai
<Batyai.Daniel at stud.u-szeged.hu>'s request for review:
Bug 124650: Move stray urls into common.config.urls
https://bugs.webkit.org/show_bug.cgi?id=124650

Attachment 217414: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=217414&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217414&action=review


> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:38
> +import webkitpy.common.config.urls as config_urls

We don't use this style of import in webkitpy.
Please import svn_server_host and svn_server_realm separately using "from ~
import ~" below.

> Tools/Scripts/webkitpy/common/net/statusserver.py:36
> +import webkitpy.common.config.urls as config_urls

Ditto.

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:-40
> +import webkitpy.common.config.urls as config_urls
>  
>  from webkitpy.common import find_files
>  from webkitpy.common.checkout.scm.detection import SCMDetector
> -from webkitpy.common.config.urls import view_source_url

This is just a bad change.