[webkit-reviews] review granted: [Bug 21371] Cannot animate "points" attribute for <svg:polygon> : [Attachment 217421] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 21371: Cannot animate "points" attribute for <svg:polygon>
https://bugs.webkit.org/show_bug.cgi?id=21371

Attachment 217421: Patch
https://bugs.webkit.org/attachment.cgi?id=217421&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=217421&action=review


> Source/WebCore/rendering/svg/SVGPathData.cpp:77
>  static void updatePathFromPolygonElement(SVGElement* element, Path& path)

You could modernize this to take SVGElement& since you are here (the argument
can't be null).

> Source/WebCore/rendering/svg/SVGPathData.cpp:92
>  static void updatePathFromPolylineElement(SVGElement* element, Path& path)

Here too.

> LayoutTests/svg/animations/polyline-set-expected.txt:6
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x600
> +  RenderSVGRoot {svg} at (10,0) size 210x220
> +    RenderSVGPath {polyline} at (10,0) size 210x220 [stroke={[type=SOLID]
[color=#FF0000] [stroke width=20.00]}] [points="10 10 210 10 210 210 10 210"]
> +    RenderSVGPath {polyline} at (10,0) size 210x220 [stroke={[type=SOLID]
[color=#008000] [stroke width=20.00]}] [points="10 10 110 10 110 110 10 110"]

Could you make a reftest instead? Render tree dumps are fragile.