[webkit-reviews] review denied: [Bug 124325] Consolidate and expose Frame/Node/Selection screenshot capabilities : [Attachment 217162] v2.3

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied	review:
Bug 124325: Consolidate and expose Frame/Node/Selection screenshot capabilities
https://bugs.webkit.org/show_bug.cgi?id=124325

Attachment 217162: v2.3
https://bugs.webkit.org/attachment.cgi?id=217162&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217162&action=review


>> Source/WebCore/page/FrameSnapshotting.cpp:86
>> +	float deviceScaleFactor = frame.page() ? 1 :
frame.page()->deviceScaleFactor();
> 
> Is this backwards? I would expect that If there is a page this should be the
page's deviceScaleFactor, otherwise 1.

Yes, the old code was:

    float deviceScaleFactor = 1;
    if (m_page)
	deviceScaleFactor = m_page->deviceScaleFactor();