[webkit-reviews] review granted: [Bug 124463] Move execution of IDBCursorBackendOperations to the IDBServerConnection : [Attachment 217139] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 124463: Move execution of IDBCursorBackendOperations to the
IDBServerConnection
https://bugs.webkit.org/show_bug.cgi?id=124463

Attachment 217139: Patch v1
https://bugs.webkit.org/attachment.cgi?id=217139&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217139&action=review


I was once (recently) made to typedef my IDs :(

> Source/WebCore/Modules/indexeddb/IDBCursorBackend.h:75
> +    void clearCursorData();

given the class name, I wonder if the CursorData suffix is necessary here (and
maybe elsewhere)

> Source/WebCore/Modules/indexeddb/IDBCursorBackend.h:87
> +    int64_t m_cursorID; // Must be destroyed before m_transaction.
> +    int64_t m_savedCursorID; // Must be destroyed before m_transaction.

Destroying int64_ts?