[webkit-reviews] review denied: [Bug 124365] REGRESSION(r159276): Lots of crashes for arm_traditional arch : [Attachment 216950] Rearrange ARM_EXTRA_GPRS in LLINT and fix cCallX macros.

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has denied Julien Brianceau
<jbriance at cisco.com>'s request for review:
Bug 124365: REGRESSION(r159276): Lots of crashes for arm_traditional arch
https://bugs.webkit.org/show_bug.cgi?id=124365

Attachment 216950: Rearrange ARM_EXTRA_GPRS in LLINT and fix cCallX macros.
https://bugs.webkit.org/attachment.cgi?id=216950&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216950&action=review


> Source/JavaScriptCore/offlineasm/arm.rb:465
> +		   $asm.puts "pop {r4-r6, r8-r12}"		  

Since r12 is a global scratch, why do we need to save it?

> Source/JavaScriptCore/offlineasm/arm.rb:471
> +		   $asm.puts "push {r4-r6, r8-r12}"

Ditto.