[webkit-reviews] review denied: [Bug 124209] [Cairo] Avoid extra copy when drawing images : [Attachment 216687] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Aloisio Almeida Jr
<aloisio.almeida at openbossa.org>'s request for review:
Bug 124209: [Cairo] Avoid extra copy when drawing images
https://bugs.webkit.org/show_bug.cgi?id=124209

Attachment 216687: Patch
https://bugs.webkit.org/attachment.cgi?id=216687&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216687&action=review


> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:181
> +    if (srcRect.x() || srcRect.y()
> +	   || srcRect.width() != cairo_image_surface_get_width(surface)
> +	   || srcRect.height() != cairo_image_surface_get_height(surface)) {

There is no guarantee that this surface is an image surface. You could simplify
this check to be:
if (srcRect.x() || srcRect.y() || srcRect.size() == cairoSurfaceSize(surface))