[webkit-reviews] review denied: [Bug 114722] [CSS Regions] clip rectangles are incorrectly computed in some positioned elements : [Attachment 216672] Repaint test

Tue Nov 12 08:36:24 PST 2013

Mihnea Ovidenie <mihnea at adobe.com> has denied Radu Stavila
<stavila at adobe.com>'s request for review:
Bug 114722: [CSS Regions] clip rectangles are incorrectly computed in some
positioned elements
https://bugs.webkit.org/show_bug.cgi?id=114722

Attachment 216672: Repaint test
https://bugs.webkit.org/attachment.cgi?id=216672&action=review

------- Additional Comments from Mihnea Ovidenie <mihnea at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216672&action=review

Looks good but you need to decide whether you want to use repaint.js or
text-based-repaint.js for this test. If you want to use repaint.js you need to
generate a png file too.

> LayoutTests/ChangeLog:3
> +	   Created test for testing repaint rects for regions and some
positioned elements.

Please clarify what you mean by "some positioned elements".

> LayoutTests/fast/repaint/increasing-region-content-height.html:4
> +		<script src="resources/repaint.js"
type="text/javascript"></script>

If you use repaint.js then you should also have a png file for the mac platform
and add lines to skip the test on other non-mac platforms where the test is
run. If you decide to use the script resources/text-based-repaint.js, then you
will have a text output file without the png. From looking at the comment
inside repaint.js, text-based-repaint.js seems the preferred way.

> LayoutTests/fast/repaint/increasing-region-content-height.html:22
> +	<body onload="runRepaintTest();">

Can you add a comment telling what the success of this test looks like?

> LayoutTests/fast/repaint/increasing-region-content-height.html:24
> +		<div class="zang">

zang? :)