[webkit-reviews] review granted: [Bug 123439] Fix reported build warnings for GTK : [Attachment 216670] Patch v3

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Tibor Mészáros
<mtibor at inf.u-szeged.hu>'s request for review:
Bug 123439: Fix reported build warnings for GTK
https://bugs.webkit.org/show_bug.cgi?id=123439

Attachment 216670: Patch v3
https://bugs.webkit.org/attachment.cgi?id=216670&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216670&action=review


You can use Tools/Scripts/prepare-ChangeLog script instead of manually creating
the changelog entry to make sure it's correct.

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=123439#c4

Remove the #c4.

> Source/WebCore/ChangeLog:6
> +	   There was a void method, that has return value in it's
documentation, so I removed it.

I said *after* the Reviewed by line, not before. Sorry to be so nitpicking but
I'm not sure commit-queue will be able to land the patch if the changelog is
not correctly formatted.

> Source/WebCore/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).

I already r+'ed the patch, you can fill this with my name and upload a new
version of the patch asking only commit-queue?