[webkit-reviews] review granted: [Bug 121562] [MSE] Implement support for SourceBuffer.remove() : [Attachment 212007] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 121562: [MSE] Implement support for SourceBuffer.remove()
https://bugs.webkit.org/show_bug.cgi?id=121562

Attachment 212007: Patch
https://bugs.webkit.org/attachment.cgi?id=212007&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212007&action=review


> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:112
> +    // FIXME: Add step 6 text when mode attribute is implemented.

Nit: bug number?

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:170
> +void SourceBuffer::remove(double start, double end, ExceptionState& es)

I think this merge was a bit too automatic ;-). Don't you mean:

void SourceBuffer::remove(double start, double end, ExceptionCode& ec)

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:176
> +	   es.throwDOMException(InvalidAccessError);

ec = INVALID_ACCESS_ERR;

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:184
> +	   es.throwDOMException(InvalidStateError);

ec = INVALID_STATE_ERR;