[webkit-reviews] review granted: [Bug 123818] Remote Layer Tree: Apply layer changes to LayerTypeCustom layers to the custom layer in the Web process, not to the CALayerHost : [Attachment 216062] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 123818: Remote Layer Tree: Apply layer changes to LayerTypeCustom layers to
the custom layer in the Web process, not to the CALayerHost
https://bugs.webkit.org/show_bug.cgi?id=123818

Attachment 216062: patch
https://bugs.webkit.org/attachment.cgi?id=216062&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216062&action=review


> Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.h:39
> +    typedef HashMap<RemoteLayerTreeTransaction::LayerID, PlatformLayer *>
RelatedLayerMap;
> +    static void applyPropertiesToLayer(PlatformLayer *,
RemoteLayerTreeTransaction::LayerProperties, RelatedLayerMap);
> +    static void disableActionsForLayer(PlatformLayer *);

Please use CALayer instead of PlatformLayer.

> Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:43
> +    RetainPtr<CGColorRef> cgColor = adoptCF(CGColorCreate(colorSpace.get(),
components));
> +    return cgColor;

Can just return adoptCF

> Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:158
> +void RemoteLayerTreePropertyApplier::disableActionsForLayer(PlatformLayer
*layer)

Again, CALayer!

> Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:162
> +    [layer setStyle:@{ @"actions" : @{
> +	   @"anchorPoint" : nullValue,

Please put @“actions” on a new line. Can also use layr.style = here I think.

> Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:173
> +	   @"zPosition" : nullValue } }];

} should be on a separate line.