[webkit-reviews] review granted: [Bug 123686] Cleanup OpenTypeUtilities : [Attachment 215831] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 123686: Cleanup OpenTypeUtilities
https://bugs.webkit.org/show_bug.cgi?id=123686

Attachment 215831: Patch
https://bugs.webkit.org/attachment.cgi?id=215831&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215831&action=review


Looks OK.

> Source/WebCore/ChangeLog:3
> +	   Cleanup OpenTypeUtilities

Cleanup is a noun. The verb is “clean up”.

> Source/WebCore/platform/graphics/wince/FontCustomPlatformData.cpp:72
>  std::unique_ptr<FontCustomPlatformData> createFontCustomPlatformData(const
SharedBuffer* buffer)

If you can assert that the buffer pointer is non-null, that’s a clue that the
argument should be a reference instead of a pointer. Would be nice to change
that at some point.