[webkit-reviews] review granted: [Bug 123674] Fix MSVC warning about unary minus operator : [Attachment 215817] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 123674: Fix MSVC warning about unary minus operator
https://bugs.webkit.org/show_bug.cgi?id=123674

Attachment 215817: Patch
https://bugs.webkit.org/attachment.cgi?id=215817&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215817&action=review


> Source/JavaScriptCore/jit/Repatch.cpp:864
> +		   stubJit.loadPtr(MacroAssembler::Address(scratchGPR3,
-static_cast<ptrdiff_t>(offset + sizeof(JSValue) + sizeof(void*))),
scratchGPR2);
> +		   stubJit.storePtr(scratchGPR2,
MacroAssembler::Address(scratchGPR1, -static_cast<ptrdiff_t>(offset +
sizeof(JSValue) + sizeof(void*))));

I think ssize_t would be better than ptrdiff_t here, but maybe Windows doesn’t
even have that type.