[webkit-reviews] review granted: [Bug 116895] fast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833 : [Attachment 203116] Update results

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 116895: fast/js/date-DST-time-cusps.html fails after
http://trac.webkit.org/changeset/150833
https://bugs.webkit.org/show_bug.cgi?id=116895

Attachment 203116: Update results
https://bugs.webkit.org/attachment.cgi?id=203116&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203116&action=review


Looks convincing.

> LayoutTests/ChangeLog:5
> +	   <rdar://problem/4777813> Safari incorrectly handles times that
shouldn't exist

Also <https://bugs.webkit.org/show_bug.cgi?id=11157>, I guess.

> LayoutTests/ChangeLog:14
> +	       - Preffer the latter option for non-existant time (due to clock
rolling forwards).

Typo: Preffer. Mistake: existant. Looks suspicious to me: forwards.

> LayoutTests/fast/js/script-tests/date-DST-time-cusps.js:6
>  "For times that happen twice the behavior of all major browsers seems to be
to pick the second occurance, i.e. Standard Time not Daylight Time"

Mistake: occurrance.