[webkit-reviews] review granted: [Bug 116935] WebSQL forces 16-bit strings : [Attachment 203307] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 116935: WebSQL forces 16-bit strings
https://bugs.webkit.org/show_bug.cgi?id=116935

Attachment 203307: Patch
https://bugs.webkit.org/attachment.cgi?id=203307&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203307&action=review


r=me, but it looks like this broke the Windows build

> Source/WTF/wtf/text/StringImpl.cpp:296
> +    unsigned length = lengthOfNullTerminatedString(string);
> +    return StringImpl::create8BitIfPossible(string, length);

I think this would be better without the local variable “length”.

> Source/WTF/wtf/text/WTFString.cpp:60
> +    size_t length = lengthOfNullTerminatedString(str);
> +    m_impl = StringImpl::create(str, length);

I think this would be better without the local variable “length”.

> Source/WebCore/platform/sql/SQLiteStatement.cpp:335
> +	   case SQLITE_TEXT: {
> +	       const UChar* string = reinterpret_cast<const
UChar*>(sqlite3_value_text16(value));
> +	       return SQLValue(StringImpl::create8BitIfPossible(string));
> +	   }

Why the local variable. Just to keep the source lines shorter?