[webkit-reviews] review denied: [Bug 116877] Optimize RenderText::offsetNext for 8 bit strings : [Attachment 203074] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 28 14:20:53 PDT 2013


Adam Barth <abarth at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 116877: Optimize RenderText::offsetNext for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=116877

Attachment 203074: Patch
https://bugs.webkit.org/attachment.cgi?id=203074&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
(In reply to comment #7)
> (From update of attachment 203074 [details])
> We obviously want something like this; if there is an issue with soft hyphen
we should be able to deal with it simply.

It looks like there is an issue with soft hyphen.

> Would be nice to have a test to be sure.

I verified that soft hypen has non-trivial cursor movement by making the
Wikipedia page for soft hypen contenteditable and moving the cursor around the
page.

> The isAllASCII part of this patch could be landed separately and already
delivers the bulk of the value.

Indeed.  /me will work on a test for the soft hypen issue.

Thanks for the review!


More information about the webkit-reviews mailing list