[webkit-reviews] review denied: [Bug 116698] [Windows] NRWT reports failure for 'mac' test cases : [Attachment 203076] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 116698: [Windows] NRWT reports failure for 'mac' test cases
https://bugs.webkit.org/show_bug.cgi?id=116698

Attachment 203076: Patch
https://bugs.webkit.org/attachment.cgi?id=203076&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203076&action=review


> Tools/Scripts/webkitpy/port/win.py:144
> +	   return dirs_to_skip

There's too much duplicated code in these routines, I think. 

What I would probably try to do is change the implementation of
_tests_for_other_platforms() in base.py to call a new test_search_path() in
base.py (like you have here), define test_search_path() in base.py as calling
baseline_search_path() (to get the same logic by default), and then override
test_search_path() in win.py to call the super method, but filter out the mac
ports.

Does that make sense?