[webkit-reviews] review granted: [Bug 116743] MessageSender shouldn't be a class template : [Attachment 202857] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 24 17:14:10 PDT 2013
Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 116743: MessageSender shouldn't be a class template
https://bugs.webkit.org/show_bug.cgi?id=116743
Attachment 202857: Patch
https://bugs.webkit.org/attachment.cgi?id=202857&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202857&action=review
> Source/WebKit2/Platform/CoreIPC/MessageSender.h:69
> + virtual Connection* messageSenderConnection() = 0;
> + virtual uint64_t messageSenderDestinationID() = 0;
r=me if you mark all overrides as both "virtual" and "OVERRIDE"
More information about the webkit-reviews
mailing list